Video: Amazing Code Reviews
Amazing Code Reviews
https://www.youtube.com/watch?v=ly86Wq_E18o
1) build the right thing
show direction
early
to minimize rework
draft PR (github)
- cannot be merged
- don't ping code owners
- communicates 'draft'
2) build the thing right
stacked PR
(pr that depend on each other)
Toolbelt
- well organized commits
- github base branches
- stacked PRs
1 PR == 1 concern
3) Build it fast
PR is not great for crowd discussion
-> meeting
add results of meeting to PR
shared responsibility
